Typescript changes for Beam 2.51.0 #28553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we upgrade proto, we need to regenerate the protos.
This is probably related to BEAM-28399; best to fix here to be explicit.
|
R: @kennknowles |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
damccorm
reviewed
Sep 20, 2023
| @@ -33,6 +33,8 @@ export function dataflowRunner(runnerOptions: { | |||
| options: Object = {} | |||
| ): Promise<PipelineResult> { | |||
| var augmentedOptions = { experiments: [] as string[], ...options }; | |||
| augmentedOptions.experiments.push("use_runner_v2"); | |||
| augmentedOptions.experiments.push("use_portable_job_submission"); | |||
There was a problem hiding this comment.
Would typescript tests have caught this? If yes, should we add python runner paths to the workflow trigger so that the tests run against python dataflow runner changes?
There was a problem hiding this comment.
Yes, the TypeScript Dataflow Tests should have caught this, but it's not generally run due to lack of credentials.
There was a problem hiding this comment.
but it's not generally run due to lack of credentials.
Not sure what this means - https://github.com/apache/beam/actions/workflows/typescript_tests.yml looks like its running consistently
damccorm
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.