Populate top-level display data in yaml main. #28512
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28512 +/- ##
==========================================
- Coverage 72.26% 72.17% -0.10%
==========================================
Files 684 686 +2
Lines 100842 101537 +695
==========================================
+ Hits 72878 73283 +405
- Misses 26384 26674 +290
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 44 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
robertwb
force-pushed
the
display-data
branch
from
db8a12d to
5c4f365
Compare
|
R: @Polber |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
sdks/python/apache_beam/yaml/main.py
Outdated
| pickle_library='cloudpickle', | ||
| **yaml_transform.SafeLineLoader.strip_metadata(pipeline_spec.get( | ||
| 'options', {})))) as p: | ||
| with beam.Pipeline( # |
There was a problem hiding this comment.
This is actually to prevent some odd yapf formatting. Clarifying.
|
I think this PR is causing docs test to fail -https://github.com/apache/beam/actions/runs/6461453740/job/17541145482?pr=28902 or I might need to rebase my PR on to master.I will check |
|
Huh. codecov was the only failure in presubmits, but it looks like a bunch didn't run. Reverting for now to diagnose. |
This reverts commit 3844972.
Reapply "Populate top-level display data in yaml main. (#28512)"
This will be useful in case the UI wants to display it.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.