Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyarrow upper bound #28437

Closed
wants to merge 2 commits into from
Closed

Bump pyarrow upper bound #28437

wants to merge 2 commits into from

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Sep 13, 2023

Upgrade allowed pyarrow dependency.

fixes: #28410

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@tvalentyn tvalentyn changed the title Update setup.py Bump pyarrow upper bound Sep 13, 2023
@tvalentyn tvalentyn marked this pull request as draft September 13, 2023 17:54
Upgrade allowed pyarrow dependency
@github-actions github-actions bot added the io label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #28437 (4a996ce) into master (1032533) will increase coverage by 0.00%.
Report is 7 commits behind head on master.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #28437   +/-   ##
=======================================
  Coverage   72.31%   72.31%           
=======================================
  Files         683      683           
  Lines      100633   100651   +18     
=======================================
+ Hits        72768    72783   +15     
- Misses      26289    26292    +3     
  Partials     1576     1576           
Flag Coverage Δ
python 82.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/setup.py 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn
Copy link
Contributor Author

looks like widows tests time out and there is a warning:

C:\arrow\cpp\src\arrow\filesystem\s3fs.cc:2829: arrow::fs::FinalizeS3 was not called even though S3 was initialized. This could lead to a segmentation fault at exit

this may be a pyarrow issue. Asked in apache/arrow#35876

Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 15, 2023
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Nov 22, 2023
@tvalentyn tvalentyn deleted the tvalentyn-patch-1 branch March 6, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new versions of pyarrow in apache-beam
1 participant