Fix numeric_only logic in frames_test for Pandas 2 #28422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Level was always NotImplemented anyway, and errors I conditionally disable based on the pandas version to keep functionality.
Pandas removed .append in 2.0 so this helps keep the API consistent.
Pandas 2 has made most args of most methods kw only. This still supports Pandas 1 while allowing for those.
Codecov Report
@@ Coverage Diff @@
## master #28422 +/- ##
==========================================
- Coverage 72.34% 72.33% -0.01%
==========================================
Files 683 683
Lines 100708 100768 +60
==========================================
+ Hits 72858 72895 +37
- Misses 26273 26296 +23
Partials 1577 1577
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
R: @tvalentyn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
tvalentyn
reviewed
Sep 15, 2023
In Pandas 1, a few methods (cor, cov, and quantile being the implemented ones for Beam) had the default behavior of numeric_only=True if not specified. In Pandas 2 the default is numeric_only=False for these. So for tests to keep passing I need to explicitly pass the argument.
caneff
force-pushed
the
numeric_only
branch
from
e35e95f to
5316fe6
Compare
tvalentyn
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Pandas 1, a few methods (cor, cov, and quantile being the implemented
ones for Beam) had the default behavior of numeric_only=True if not
specified. In Pandas 2 the default is numeric_only=False for these. So for tests to
keep passing I need to explicitly pass the argument.
Partially fixes #27221.