Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to control automatic exception sampling in Java (disabled) #28403

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

rohdesamuel
Copy link
Contributor

Automatic exception samplingThis enables exception sampling when either the "enable_data_sampling" or "enable_always_on_exception_sampling" experiment is present. This disables automatic exception sampling when "disable_always_on_exception_sampling" is given.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@rohdesamuel
Copy link
Contributor Author

R: @udim

@github-actions github-actions bot added the java label Sep 11, 2023
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@udim
Copy link
Member

udim commented Sep 12, 2023

Run Java PreCommit

1 similar comment
@rohdesamuel
Copy link
Contributor Author

Run Java PreCommit

@udim
Copy link
Member

udim commented Sep 13, 2023

Run Java PreCommit

edit: whoops wrong one

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Test Results

  1 235 files    1 235 suites   1h 55m 54s ⏱️
10 262 tests 10 193 ✔️ 68 💤 1
10 286 runs  10 217 ✔️ 68 💤 1

For more details on these failures, see this check.

Results for commit 91d1e6f.

♻️ This comment has been updated with latest results.

@rohdesamuel
Copy link
Contributor Author

rohdesamuel commented Sep 14, 2023

For some reason, Jenkins is running an "@ ignored" test:
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java#L2858

and this is the test that is causing the test failures.

@udim udim merged commit 5df59a9 into apache:master Sep 14, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants