-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Warn users about misspelled pipeline options #28402
Comments
Validated that the warning is shown while running on Direct runner but not for Dataflow runner on master |
I think this is the actual change which prevented the warnings https://github.com/apache/beam/pull/22132/files |
On dataflow runner it is not shown because we are retaining the pipeline options. So any unknown flag is getting added as a valid argument and parsed again. This seems to be working as intended. But as a caution, we can add a log stating that unknown arg found. WDYT @tvalentyn ? |
I can still see "Discarding unparseable args" in recent dataflow pipeline, e.g. this load test: "2023-11-17_07_58_43-10220172113544842485", run in https://github.com/apache/beam/actions/runs/6906173679/job/18790592122 |
There is probably some off-the-shelf library or algorithm we can reuse to detect misspellings specifically. |
Sounds good.. I'll take a look on this more |
It's in Dataflow worker log |
What would you like to happen?
I believe after 3dcdcf3 we are no longer getting warnings like "Discarding unparseable args".
It is very easy to mistype an option. For example, one can supply
--extra-package
instead of--extra_package
, which I did. In 2.40.0 I would have gottenWARNING:apache_beam.options.pipeline_options:Discarding unparseable args: ['--extra-package=package.whl']
in console logs, but we are not getting such logs anymore.We should warn users about incorrect options, or even better suggest corrections: did you mean X ?
Issue Priority
Priority: 2 (default / most feature requests should be filed as P2)
Issue Components
The text was updated successfully, but these errors were encountered: