Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace triggers #28401

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix whitespace triggers #28401

merged 2 commits into from
Sep 12, 2023

Conversation

damccorm
Copy link
Contributor

Right now, this only triggers on md/gradle changes in the base directory, this fixes the problem.

Example PR where the triggers didn't fire but should've - #28315


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

R: @andreydevyatkin

@github-actions github-actions bot added the build label Sep 11, 2023
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor

Abacn commented Sep 12, 2023

ah, also noticed in https://github.com/apache/beam/pull/28316/files#r1323169313 (but the path was still wrong in my PR). We also need to include 'build.gradle.kts'

@damccorm
Copy link
Contributor Author

ah, also noticed in https://github.com/apache/beam/pull/28316/files#r1323169313 (but the path was still wrong in my PR). We also need to include 'build.gradle.kts'

Done!

@damccorm damccorm merged commit 7cb4371 into master Sep 12, 2023
3 checks passed
@damccorm damccorm deleted the users/damccorm/whitespaceTrigger branch September 12, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants