Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java variants of WriteTo{Csv,Json}. #28380

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Sep 8, 2023


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@robertwb
Copy link
Contributor Author

robertwb commented Sep 8, 2023

R: @Abacn

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #28380 (5037d7c) into master (76fbb8e) will decrease coverage by 0.06%.
Report is 8 commits behind head on master.
The diff coverage is 1.63%.

@@            Coverage Diff             @@
##           master   #28380      +/-   ##
==========================================
- Coverage   72.23%   72.17%   -0.06%     
==========================================
  Files         685      686       +1     
  Lines      101519   101551      +32     
==========================================
- Hits        73328    73296      -32     
- Misses      26614    26676      +62     
- Partials     1577     1579       +2     
Flag Coverage Δ
python 82.62% <1.63%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/python/apache_beam/testing/analyzers/__init__.py 100.00% <100.00%> (ø)
...ache_beam/testing/analyzers/github_issues_utils.py 0.00% <0.00%> (-40.91%) ⬇️
...hon/apache_beam/testing/analyzers/perf_analysis.py 16.21% <0.00%> (-0.69%) ⬇️
...ache_beam/testing/analyzers/perf_analysis_utils.py 13.84% <0.00%> (-4.61%) ⬇️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robertwb
Copy link
Contributor Author

robertwb commented Oct 6, 2023

R: @johnjcasey

I think the Jenkins failures are infra issues.

@robertwb robertwb merged commit dafe928 into apache:master Oct 9, 2023
2 of 3 checks passed
@github-actions github-actions bot added the yaml label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants