Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WindmillStateReader to not batch OrderedListFetches for the same family and tag. #28371

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

scwhittle
Copy link
Contributor

@scwhittle scwhittle commented Sep 8, 2023

Fix issue with MultimapState delayed fetches due to batching.

fixes #28370


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@scwhittle scwhittle closed this Sep 8, 2023
@scwhittle scwhittle reopened this Sep 8, 2023
@scwhittle
Copy link
Contributor Author

R: @reuvenlax

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@scwhittle scwhittle closed this Sep 18, 2023
@scwhittle scwhittle reopened this Sep 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Test Results

  1 269 files  +1 123    1 269 suites  +1 123   1h 48m 25s ⏱️ + 1h 18m 13s
10 629 tests +9 295  10 561 ✔️ +9 260  68 💤 +35  0 ±0 
10 653 runs  +9 317  10 585 ✔️ +9 282  68 💤 +35  0 ±0 

Results for commit 231aed7f. ± Comparison against base commit 7ba4fa9.

This pull request removes 9 and adds 9302 tests. Note that renamed tests count towards both.
id]
id`]
org.apache.beam.sdk.extensions.sql.CalciteCannotParseSimpleIdentifiersTest ‑ testFailsToParseAlias[`field
org.apache.beam.sdk.extensions.sql.CalciteCannotParseSimpleIdentifiersTest ‑ testFailsToParseAlias[field
org.apache.beam.sdk.extensions.sql.impl.LazyAggregateCombineFnTest$UdafImplTest ‑ subclassGetUdafImpl[aggregateFn: org.apache.beam.sdk.extensions.sql.impl.LazyAggregateCombineFnTest$Sum@4d49981a]
org.apache.beam.sdk.extensions.sql.impl.LazyAggregateCombineFnTest$UdafImplTest ‑ subclassGetUdafImpl[aggregateFn: org.apache.beam.sdk.extensions.sql.impl.LazyAggregateCombineFnTest$SumChild@3e217c41]
org.apache.beam.sdk.testutils.jvmverification.JvmVerification ‑ verifyCodeIsCompiledWithJava8
org.apache.beam.sdk.testutils.jvmverification.JvmVerification ‑ verifyRunningJVMVersionIs17
org.apache.beam.sdk.testutils.jvmverification.JvmVerification ‑ verifyTestCodeIsCompiledWithJava17
DefaultPackageTest ‑ defaultPackageInvoker
org.apache.beam.examples.DebuggingWordCountTest ‑ testDebuggingWordCount
org.apache.beam.examples.MinimalWordCountTest ‑ testMinimalWordCount
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInBatchDynamicSharding
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInBatchStaticSharding
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInStreamingStaticSharding
org.apache.beam.examples.WordCountIT ‑ testE2EWordCount
org.apache.beam.examples.WordCountTest ‑ testCountWords
org.apache.beam.examples.WordCountTest ‑ testExtractWordsFn
org.apache.beam.examples.complete.AutoCompleteTest ‑ testAutoComplete[0]
…

♻️ This comment has been updated with latest results.

@scwhittle
Copy link
Contributor Author

Run Java PreCommit

…me family and tag. Fix issue with MultimapState delayed fetches due to batching.
@scwhittle
Copy link
Contributor Author

R: @y1chi

@reuvenlax
Copy link
Contributor

reuvenlax commented Oct 31, 2023 via email

@scwhittle
Copy link
Contributor Author

Run Java PreCommit

@scwhittle
Copy link
Contributor Author

previous failure was unrelated flink test timeout

@reuvenlax
Copy link
Contributor

LGTM

@reuvenlax reuvenlax merged commit 2a96ced into apache:master Nov 1, 2023
18 checks passed
@scwhittle scwhittle deleted the ordered_list branch December 15, 2023 13:08
@scwhittle scwhittle restored the ordered_list branch April 2, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants