-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change WindmillStateReader to not batch OrderedListFetches for the same family and tag. #28371
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
R: @reuvenlax |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Test Results 1 269 files +1 123 1 269 suites +1 123 1h 48m 25s ⏱️ + 1h 18m 13s Results for commit 231aed7f. ± Comparison against base commit 7ba4fa9. This pull request removes 9 and adds 9302 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Run Java PreCommit |
…me family and tag. Fix issue with MultimapState delayed fetches due to batching.
231aed7
to
97354ee
Compare
R: @y1chi |
Taking a look.
…On Tue, Oct 31, 2023 at 6:37 AM scwhittle ***@***.***> wrote:
R: @y1chi <https://github.com/y1chi>
—
Reply to this email directly, view it on GitHub
<#28371 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAYJVNBF6B6F55AV4BEKSDYCD5INAVCNFSM6AAAAAA4QHW52GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGIZTKOJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Run Java PreCommit |
previous failure was unrelated flink test timeout |
LGTM |
Fix issue with MultimapState delayed fetches due to batching.
fixes #28370
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.