Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase transform service timeout #28267

Conversation

chamikaramj
Copy link
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@chamikaramj chamikaramj marked this pull request as ready for review August 31, 2023 17:53
@chamikaramj
Copy link
Contributor Author

Run TransformService_Direct PostCommit

1 similar comment
@chamikaramj
Copy link
Contributor Author

Run TransformService_Direct PostCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #28267 (3d07841) into master (3e2b9b2) will increase coverage by 0.09%.
Report is 43 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #28267      +/-   ##
==========================================
+ Coverage   72.29%   72.38%   +0.09%     
==========================================
  Files         678      679       +1     
  Lines       99959   100213     +254     
==========================================
+ Hits        72261    72544     +283     
+ Misses      26123    26094      -29     
  Partials     1575     1575              
Flag Coverage Δ
python 82.97% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...on/apache_beam/utils/transform_service_launcher.py 24.44% <100.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chamikaramj
Copy link
Contributor Author

Run Python_Transforms PreCommit"

@chamikaramj
Copy link
Contributor Author

Run TransformService_Direct PostCommit

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Reminder, please take a look at this pr: @damccorm @Abacn

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@damccorm
Copy link
Contributor

stop reviewer notifications

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer

@chamikaramj
Copy link
Contributor Author

Thanks.

@chamikaramj chamikaramj merged commit 5696c59 into apache:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants