Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: FlinkDetachedRunnerResult violates the contract by not properly handling wait times of less than 1 ms #28258

Closed
1 of 15 tasks
ddebowczyk92 opened this issue Aug 31, 2023 · 1 comment

Comments

@ddebowczyk92
Copy link
Contributor

ddebowczyk92 commented Aug 31, 2023

What happened?

According to the documentation on the PipelineResult.waitUntilFinish(Duration duration) , if duration value is less than 1ms it should wait infinitely. FlinkDetachedRunnerResult breaks this contract - if the provided will be less than 1ms it will skip the while loop and return the state immediately.

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
ddebowczyk92 added a commit to ddebowczyk92/beam that referenced this issue Sep 5, 2023
… less than 1ms in FlinkDetachedRunnerResult
@ddebowczyk92 ddebowczyk92 removed their assignment Sep 5, 2023
je-ik added a commit that referenced this issue Sep 21, 2023
@je-ik
Copy link
Contributor

je-ik commented Sep 21, 2023

Closed via #28262.

@je-ik je-ik closed this as completed Sep 21, 2023
@github-actions github-actions bot added this to the 2.52.0 Release milestone Sep 21, 2023
kennknowles pushed a commit to kennknowles/beam that referenced this issue Sep 22, 2023
… less than 1ms in FlinkDetachedRunnerResult
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants