Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Flattening PCollections with incompatible windowing should be a construction-time error. #22903

Closed
robertwb opened this issue Aug 25, 2022 · 1 comment · Fixed by #30410
Closed

[Bug]: Flattening PCollections with incompatible windowing should be a construction-time error. #22903

robertwb opened this issue Aug 25, 2022 · 1 comment · Fixed by #30410
Assignees
@damccorm
Labels
bug core good first issue P2 python
Milestone
2.55.0 Release

Comments

@robertwb
Copy link
Contributor

What happened?

Logically, a PCollection should have a single type of window. Not catching this at construction time can lead to odd errors on runners.

Issue Priority

Priority: 2

Issue Component

Component: sdk-py-core
@tvalentyn
Copy link
Contributor

Can windows be directly comparable or some logic is necessary to decide whether they are compatible?

@github-actions github-actions bot added the stale label Oct 30, 2022
@damccorm damccorm removed the stale label Dec 2, 2022
@damccorm damccorm self-assigned this Feb 21, 2024
@damccorm damccorm mentioned this issue Feb 23, 2024
Merged
3 tasks
@github-actions github-actions bot added this to the 2.55.0 Release milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damccorm damccorm

Labels
bug core good first issue P2 python
Projects
None yet
Milestone
2.55.0 Release
Development

Successfully merging a pull request may close this issue.

Ensure flatten windows match damccorm/beam
3 participants
@robertwb @tvalentyn @damccorm