Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a provider to create JMS ConnectionFactory and avoid Serialization issues #18110

Open
kennknowles opened this issue Jun 3, 2022 · 2 comments
Open

Use a provider to create JMS ConnectionFactory and avoid Serialization issues #18110

kennknowles opened this issue Jun 3, 2022 · 2 comments
Assignees
@tilgalas
Labels
improvement io java jms P3

Comments

@kennknowles
Copy link
Member

The JmsIO uses JMS ConnectionFactory as configuration. Unfortunately, ConnectionFactory interface doesn't extend Serializable (even if most of the implementations are Serializable).
Instead (as I'm doing for the JdbcIO), I propose to create a ConnectionFactoryConfiguration POJO to create the ConnectionFactory in the @Setup of the reader and writer.

Imported from Jira BEAM-676. Original Jira may contain additional context.
Reported by: jbonofre.
@tilgalas
Copy link
Contributor

.take-issue

@tilgalas tilgalas mentioned this issue May 13, 2024
Merged
3 tasks
@tilgalas
Copy link
Contributor

I guess we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tilgalas tilgalas

Labels
improvement io java jms P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennknowles @tilgalas @damccorm