From 15fe088cbaba64cca3ac8c2036576bbf4f9e5cc6 Mon Sep 17 00:00:00 2001 From: Danny McCormick Date: Tue, 10 Sep 2024 13:04:23 -0400 Subject: [PATCH] Dont run flaky test on windows --- sdks/python/apache_beam/ml/inference/base_test.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdks/python/apache_beam/ml/inference/base_test.py b/sdks/python/apache_beam/ml/inference/base_test.py index 359a372bc5b0..31f02c9c61c5 100644 --- a/sdks/python/apache_beam/ml/inference/base_test.py +++ b/sdks/python/apache_beam/ml/inference/base_test.py @@ -878,10 +878,10 @@ def test_run_inference_timeout_not_hit(self): bad_without_error, equal_to(expected_bad), label='assert:failures') @unittest.skipIf( - sys.version_info < (3, 11), + sys.platform == "win32" or sys.version_info < (3, 11), "This test relies on the __del__ lifecycle method, but __del__ does " + - "not get invoked in the same way on older versions of Python, " + - "breaking this test. See " + + "not get invoked in the same way on older versions of Python or on " + + "windows, breaking this test. See " + "github.com/python/cpython/issues/87950#issuecomment-1807570983 " + "for example.") def test_run_inference_timeout_does_garbage_collection(self):