Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit job is failing on main #433

Closed
raulcd opened this issue Nov 28, 2024 · 1 comment
Closed

pre-commit job is failing on main #433

raulcd opened this issue Nov 28, 2024 · 1 comment
Labels
Type: bug Something isn't working

Comments

@raulcd
Copy link
Member

raulcd commented Nov 28, 2024

Describe the bug, including details regarding any error messages, version, and platform.

There's a couple of pre-commit failures currently on main:

diff --git a/.gitignore b/.gitignore
index 3ac6ed5f..707f506e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,6 +13,7 @@
 .settings/
 /*-build/
 /.mvn/.develocity/
+/.mvn/.develocity/
 /build/
 /dev/release/apache-rat-0.16.1.jar
 /dev/release/filtered_rat.txt
@@ -26,4 +27,3 @@ cmake_install.cmake
 dependency-reduced-pom.xml
 install_manifest.txt
 target/
-/.mvn/.develocity/
diff --git a/arrow-format/FlightSql.proto b/arrow-format/FlightSql.proto
index ef1ae751..3568d851 100644
--- a/arrow-format/FlightSql.proto
+++ b/arrow-format/FlightSql.proto
@@ -1857,7 +1857,7 @@ message DoPutPreparedStatementResult {
   // statement should be considered invalid, and all subsequent requests for this prepared
   // statement must use this new handle.
   // The updated handle allows implementing query parameters with stateless services.
-  // 
+  //
   // When an updated handle is not provided by the server, clients should contiue
   // using the previous handle provided by `ActionCreatePreparedStatementResonse`.
   optional bytes prepared_statement_handle = 1;
diff --git a/arrow-format/Schema.fbs b/arrow-format/Schema.fbs
index e8e14b11..7ba9aaf7 100644
--- a/arrow-format/Schema.fbs
+++ b/arrow-format/Schema.fbs
@@ -216,14 +216,14 @@ table Bool {
 
 /// Contains two child arrays, run_ends and values.
 /// The run_ends child array must be a 16/32/64-bit integer array
-/// which encodes the indices at which the run with the value in 
+/// which encodes the indices at which the run with the value in
 /// each corresponding index in the values child array ends.
 /// Like list/struct types, the value array can be of any type.
 table RunEndEncoded {
 }
 
 /// Exact decimal value represented as an integer value in two's
-/// complement. Currently 32-bit (4-byte), 64-bit (8-byte), 
+/// complement. Currently 32-bit (4-byte), 64-bit (8-byte),
 /// 128-bit (16-byte) and 256-bit (32-byte) integers are used.
 /// The representation uses the endianness indicated in the Schema.
 table Decimal {
diff --git a/arrow-format/substrait/extension_types.yaml b/arrow-format/substrait/extension_types.yaml
index 0073da1a..4c0ef8ee 100644
--- a/arrow-format/substrait/extension_types.yaml
+++ b/arrow-format/substrait/extension_types.yaml
@@ -48,7 +48,7 @@
 #  *  Functions have the same meaning when applied to the encoded type
 #
 # Note: if two types have a different range (e.g. string and large_string) then
-# they do not satisfy the above criteria and are not encodings. 
+# they do not satisfy the above criteria and are not encodings.
 #
 # These types will never have a Substrait equivalent.  In the Substrait point
 # of view these are execution details.
@@ -167,4 +167,3 @@ types:
     parameters:
       - name: unit
         type: string
-
Error: Process completed with exit code 1.
@raulcd raulcd added the Type: bug Something isn't working label Nov 28, 2024
@raulcd
Copy link
Member Author

raulcd commented Nov 28, 2024

ok, just saw @lidavidm is fixing those here:
#432

@raulcd raulcd closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant