-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(csharp/src/Drivers/Apache): add connect and query timeout options #2312
base: main
Are you sure you want to change the base?
feat(csharp/src/Drivers/Apache): add connect and query timeout options #2312
Conversation
…s - unimplemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One small nit (that I should have done already).
…ancellationToken fully
@@ -6,6 +6,7 @@ | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="ApacheThrift" Version="0.21.0" /> | |||
<PackageReference Include="System.Net.Http" Version="4.3.4" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this reference as the ApacheThrift
references version 4.3.0
which is marked as vulnerable.
Note: because we can't pass the same cancellation token to ExecuteQueryAsync and the ReadNextBatchAsync, the runtime may exceed the query timeout |
Added issue and submitted PR to ensure rethrown exceptions include the original exception. |
Converted to draft because I'm trying to resolve failing tests |
These have changed now. |
@CurtHagenlocher - A lot of churn on this PR - but I'd say it is ready for review, if you have the time. Thanks. |
Adds options for command and query timeout
adbc.spark.connect_timeout_ms
30000
adbc.apache.statement.query_timeout_s
60