Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/adbc/driver/snowflake: add option for unquoted table name #1766

Open
lidavidm opened this issue Apr 25, 2024 · 2 comments · May be fixed by #1800
Open

go/adbc/driver/snowflake: add option for unquoted table name #1766

lidavidm opened this issue Apr 25, 2024 · 2 comments · May be fixed by #1800
Labels
Type: enhancement New feature or request

Comments

@lidavidm
Copy link
Member

What feature or improvement would you like to see?

Based on #1721 and #1738 I think we can add an option like adbc.snowflake.sql.unsafe_disable_table_name_quoting to let you pass an unquoted table name to ingestion APIs, for power users who have pre-escaped table names.
@lidavidm lidavidm added the Type: enhancement New feature or request label Apr 25, 2024
@lidavidm lidavidm mentioned this issue Apr 25, 2024
Merged
@zeroshade
Copy link
Member

It was suggested by @davlee1972 that we name it adbc.snowflake.sql.unsafe_disable_quoted_identifiers instead since "quoted_identifiers" is a common term / commonly used in various database driver utilities. I'm okay with this naming if others are

@davlee1972
Copy link

davlee1972 commented Apr 25, 2024 •
edited
Loading

Sorry for the back and forth.. I think it should called "quote_identifiers" = True by default..

This is a common term used across database products and with common understanding..

A quoted identifier begins and ends with double quotation marks (").

https://www.postgresql.org/docs/current/sql-syntax-lexical.html
There is a second kind of identifier: the delimited identifier or quoted identifier. It is formed by enclosing an arbitrary sequence of characters in double-quotes (").

https://docs.oracle.com/cd/B10500_01/server.920/a96540/sql_elements9a.htm
Every database object has a name. In a SQL statement, you represent the name of an object with a quoted identifier or a nonquoted identifier.

https://docs.snowflake.com/en/sql-reference/identifiers-syntax
To work around this limitation, Snowflake provides the QUOTED_IDENTIFIERS_IGNORE_CASE session

@zeroshade zeroshade linked a pull request Apr 30, 2024 that will close this issue
Open
@github-actions github-actions bot added this to the ADBC Libraries 1.0.0 milestone Apr 30, 2024
@lidavidm lidavidm removed this from the ADBC Libraries 1.0.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(go/adbc/driver/snowflake): add quoted identifier ignore case option zeroshade/arrow-adbc
3 participants
@lidavidm @zeroshade @davlee1972