Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default number of DOE points for SurrogateAssistedAlgorithm class #7

Open
AngusKenny opened this issue Jun 7, 2024 · 0 comments
Open

Comments

@AngusKenny
Copy link

In pysamoo.core.algorithm, the docstring for the SurrogateAssistedAlgorithm class states that if n_initial_doe = None, "the default is 11n - 1 (but at most n_max_doe)".

Further down, in _setup(), it sets the number of initial DOE points to:
self.n_initial_doe = min(self.n_initial_max_doe, default_n_doe(problem.n_var))

Then at the top of pysamoo.core.algorithm it has the definition for default_n_doe as:

def default_n_doe(n, max=float("inf")):
    return min(2 * n + 1, max)

This suggests the number of initial DOE points would default to 2n + 1, instead of 11n - 1. Is the docstring incorrect or is default_n_doe defined incorrectly? I am using this code in my research, and I just want to be sure that I am using the correct defaults.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant