Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished live streams won't play #579

Closed
AlexNk opened this issue Feb 11, 2024 · 18 comments · Fixed by #588
Closed

Finished live streams won't play #579

AlexNk opened this issue Feb 11, 2024 · 18 comments · Fixed by #588
Labels
bug Something isn't working

Comments

@AlexNk
Copy link

AlexNk commented Feb 11, 2024

  • Add-on Version: 7.0.3 - beta3 and older
  • Kodi Version: LibreELEC 11.0.6

Regular videos and active live streams play fine, but some of the finished live streams won't play.
Example: https://www.youtube.com/watch?v=2aAkIxrJN3s

"Use alternative player" and "Use YouTube website URLs" are disabled.
InputStream Helper is installed

I tried searching the issues and updating/re-installing the addons, but nothing works.

Logs:

2024-02-11 14:09:34.719 T:990      info <general>: [plugin.video.youtube] Running: YouTube (7.0.3+beta.3+unofficial.1) on Nexus (Kodi-20.3) with Python 3.11.2
                                                   Path: /play/
                                                   Params: {'video_id': '2aAkIxrJN3s'}
2024-02-11 14:09:35.312 T:752      info <general>: VideoPlayer::OpenFile: plugin://plugin.video.youtube/play/?video_id=2aAkIxrJN3s
2024-02-11 14:09:35.313 T:2587     info <general>: Creating InputStream
2024-02-11 14:09:35.314 T:2587     info <general>: AddOnLog: inputstream.adaptive: [Repr. chooser] Resolution set: 1920x1080, max allowed: 1920x1080, Adjust refresh rate: 0
2024-02-11 14:09:35.316 T:2587    error <general>: CCurlFile::Open - <http://127.0.0.1:50152/youtube/manifest/dash/2aAkIxrJN3s.mpd/mpd_version/5> Failed with code 404:
                                                   
2024-02-11 14:09:35.316 T:2587    error <general>: AddOnLog: inputstream.adaptive: CURLOpen returned an error, download failed: http://127.0.0.1:50152/youtube/manifest/dash/2aAkIxrJN3s.mpd/mpd_version/5
2024-02-11 14:09:35.316 T:2587    error <general>: AddOnLog: inputstream.adaptive: Could not open / parse manifest (http://127.0.0.1:50152/youtube/manifest/dash/2aAkIxrJN3s.mpd/mpd_version/5)
2024-02-11 14:09:35.316 T:2587    error <general>: CVideoPlayer::OpenInputStream - error opening [plugin://plugin.video.youtube/play/?video_id=2aAkIxrJN3s]
2024-02-11 14:09:35.316 T:2587     info <general>: CVideoPlayer::OnExit()
2024-02-11 14:09:35.316 T:2587     info <general>: ADDON: Dll Destroyed - InputStream Adaptive
2024-02-11 14:09:35.428 T:752      info <general>: CVideoPlayer::CloseFile()

@AlexNk AlexNk added the bug Something isn't working label Feb 11, 2024
@AlexNk AlexNk changed the title Finiahed live streams won't play Finished live streams won't play Feb 11, 2024
@MoojMidge
Copy link
Collaborator

Hmm that's odd. There was a previous issue where completed live streams were indicating they were live even when they weren't, and there were no live stream manifests urls available to use.

In this issue it seems that the stream is still indicating it is live when it isn't, and that there is a manifest url present, but it is empty. Easy enough to fix, but I think the real issue is that this is a isPostLiveDvr video stream, i.e. caught in the middle of processing, but the original live video stream is no longer available to use.

Where you able to view the video on the website at the same time that it didn't work in the plugin?

@AlexNk
Copy link
Author

AlexNk commented Feb 11, 2024

Where you able to view the video on the website at the same time that it didn't work in the plugin?

Yes. All of such videos play fine in Web Browser, and Android app. And they are still in my Subscriptions or can be found by search.

MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Feb 12, 2024
- isPostLiveDvr is still ignored
- still check actual manifest types and available video formats instead of status
- fix scenario where empty dashManifestUrl is present
- Fix anxdpanic#579
@MoojMidge
Copy link
Collaborator

This is normally only a temporary issue, but to be clear, when you say the following:

Yes. All of such videos play fine in Web Browser, and Android app. And they are still in my Subscriptions or can be found by search.

Does the problem eventually resolve itself, or do these videos never work?

Anyway should be fixed by MoojMidge@50fa66b

@AlexNk
Copy link
Author

AlexNk commented Feb 12, 2024

Does the problem eventually resolve itself, or do these videos never work?

It seems that it solves in about a week. I checked with several videos that didn't play before, and those that were issued more than 6-7 days ago are playing fine now.

Anyway should be fixed by MoojMidge@50fa66b

I used this commit with 7.0.3 beta3 and the videos still won't play, but the logs look different now:

2024-02-12 11:06:46.170 T:754      info <general>: VideoPlayer::OpenFile: https://www.youtube.com/live/2aAkIxrJN3s?si=7UPfdhyLCTfEryuL
2024-02-12 11:06:46.976 T:813      info <general>: Creating InputStream
2024-02-12 11:06:47.246 T:813      info <general>: Creating Demuxer
2024-02-12 11:06:47.665 T:791      info <general>: PVR Manager: Starting cleanup of cached images.
2024-02-12 11:06:48.180 T:813     error <general>: Open - error probing input format, https://www.youtube.com/live/2aAkIxrJN3s?si=7UPfdhyLCTfEryuL
2024-02-12 11:06:48.180 T:813     error <general>: OpenDemuxStream - Error creating demuxer
2024-02-12 11:06:48.180 T:813      info <general>: CVideoPlayer::OnExit()
2024-02-12 11:06:48.195 T:754      info <general>: Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY
2024-02-12 11:06:48.200 T:754      info <general>: CVideoPlayer::CloseFile()
2024-02-12 11:06:48.200 T:754      info <general>: VideoPlayer: waiting for threads to exit
2024-02-12 11:06:48.200 T:754      info <general>: VideoPlayer: finished waiting
2024-02-12 11:06:48.320 T:791      info <general>: PVR Manager: Cleaned up 0 cached images.

Does it mean that the original problem is fixed and something else is wrong? Maybe it needs some configuration?
Should I close the issue?

@MoojMidge
Copy link
Collaborator

It looks like you have the Use YouTube website URLs option enabled

@AlexNk
Copy link
Author

AlexNk commented Feb 12, 2024

It looks like you have the Use YouTube website URLs option enabled

No. I am aware of this issue, so I specially checked that it is disabled and double-checked after updating the module.

@MoojMidge
Copy link
Collaborator

I'm out of guesses.

The plugin does not use urls in the form that is shown in your second log snippet. Not actually sure you are even running the plugin from that snippet.

The proposed fix will resolve the issue shown in your first log snippet, but if there is another problem you will need to provide a complete debug log.

@AlexNk
Copy link
Author

AlexNk commented Feb 12, 2024

OK. As the original error no longer happens I will close this ticket and wait for the next release. Then will either re-open it or create a new one.

@AlexNk AlexNk closed this as completed Feb 12, 2024
@MoojMidge
Copy link
Collaborator

I'll be honest with you - not providing a full log is a massive waste of time and I'm not going to have much interest in looking into this again without it.

@AlexNk
Copy link
Author

AlexNk commented Feb 12, 2024

I'll be honest with you - not providing a full log is a massive waste of time and I'm not going to have much interest in looking into this again without it.

Noted. My bad. Next time will attach a full debug log.

@MoojMidge MoojMidge linked a pull request Feb 23, 2024 that will close this issue
@AlexNk
Copy link
Author

AlexNk commented Mar 24, 2024

The issue became reproducible again on v7.0.4+beta.2 - unofficial

THe full debug log is attached
kodi.log

@AlexNk AlexNk reopened this Mar 24, 2024
@MoojMidge
Copy link
Collaborator

You are trying to open Youtube website urls.

Not sure how you are trying to do this, maybe through the JSONRPC or web interface, but the plugin is not even being used.

@AlexNk
Copy link
Author

AlexNk commented Mar 24, 2024

I'm sending it from Android app via KORE. So it isn't supposed to work?

@MoojMidge
Copy link
Collaborator

Isn't this you? xbmc/Kore#966

@AlexNk
Copy link
Author

AlexNk commented Mar 24, 2024

Isn't this you? xbmc/Kore#966

Yes. With SendToKodi it worked more or less stable until the recent updates. To me it's not clear what causes the issue.

@MoojMidge
Copy link
Collaborator

MoojMidge commented Mar 24, 2024

This was already answered in that linked issue. None of this is related to this plugin, it is not even being asked to run.

SendToKodi doesn't use this plugin, so whatever it is doing has nothing to do with this plugin either, let alone any recent updates of this plugin.

Not sure who is looking after Kore, but what they should probably do is just pass the Youtube url directly to the plugin instead of trying, and failing, to parse it based on a limited number of matching patterns.

plugin://plugin.video.youtube/uri2addon?uri=

@AlexNk
Copy link
Author

AlexNk commented Mar 24, 2024

SendToKodi doesn't use this plugin, so whatever it is doing has nothing to with any recent updates of this plugin.

I see. Thanks for the explanation. This was probably a coincidence.

@MoojMidge
Copy link
Collaborator

MoojMidge commented Mar 24, 2024

If you want this to work I would recommend updating your existing Kore issue and identifying the option to use plugin://plugin.video.youtube/uri2addon/?uri= directly with the YouTube url rather than having Kore parse the url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants