Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Videos From Subscriptions To Watch Later Causes Focus To Shift Down Two Places Instead Of One #1012

Open
jmh2002 opened this issue Dec 4, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@jmh2002
Copy link

jmh2002 commented Dec 4, 2024

Adding Videos From My Subscriptions To Watch Later Causes Focus To Shift Down Two Places Instead Of One.

Videos are added by a key press which sends the following command:
RunPlugin(plugin://plugin.video.youtube/playlist/add/video/?playlist_id=watch_later)

NB: adding to Watch Later via the Context Menu does not cause this problem (no shift of focus).

NB: This setup has worked correctly for a long time over previous generations of Kodi and the addon. It's not something that I have newly added.

Please provide any relevant information about your setup

  • Add-on Version: v7.1.1.3 (but this problem has existed for quite some time, sorry for not catching it immediately)
  • Kodi Version: v21.1
  • Kodi GUI Language: English
  • Operating System: ChromeOS (using Kodi Android app)
  • Operating System Language: English

Expected Behavior

Please describe the behavior you are expecting.

Focus should only shift down one place instead of two (or not even shift at all?).


Current Behavior

What is the current behavior?

Adding Videos From My Subscriptions To Watch Later Causes Focus To Shift Sown Two Places Instead Of One.


Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Open My Subscriptions
  2. Add a video to Watch Later as described above

Log

Please include a complete debug log.

paste.kodi.tv/xenaqequmu.kodi


Additional Information

Please provide any additional information that may be helpful.


@jmh2002 jmh2002 added the bug Something isn't working label Dec 4, 2024
@jmh2002 jmh2002 changed the title Adding Videos From Subscriptions To Watch Later Causes Focus To Shift Sown Two Places Instead Of One Adding Videos From Subscriptions To Watch Later Causes Focus To Shift Down Two Places Instead Of One Dec 5, 2024
@MoojMidge
Copy link
Collaborator

I can't replicate this and I also can't see anything wrong in the code, at the moment, that could cause this to occur.

Are you able to edit the code on your device to test something? If so, can you see what happens if you change this:

if keymap_action:
context.get_ui().set_focus_next_item()

From:

    if keymap_action:
        context.get_ui().set_focus_next_item()

To:

    if keymap_action and False:
        context.get_ui().set_focus_next_item()

@jmh2002
Copy link
Author

jmh2002 commented Dec 5, 2024

Thanks for looking into this.

I changed line 58 as instructed above and this seems to have solved the problem 🙂
There is now NO change of focus at all after adding to Watch Later via a Keystroke & Command.

This now matches the behaviour when adding via the Context Menu so that seems reasonable as far as UI consistency is concerned.

Thanks again 👍🏻

@MoojMidge
Copy link
Collaborator

This now matches the behaviour when adding via the Context Menu so that seems reasonable as far as UI consistency is concerned.

This is not really a solution though. The keymap behaviour was implemented to mimic Kodi behaviour where mapped actions on listitems in a listing, such as queing, would also cause the focus to shift down in the listing.

What the test does show is that the focus is not shifting twice, but that it is only happening once but moving down twice. No idea why this could be occuring, but can you try and see whether it moves down twice when using the default Estuary skin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants