From 6ec03699a3eddd01e83bca7ba62132c4baec2f80 Mon Sep 17 00:00:00 2001 From: MoojMidge <56883549+MoojMidge@users.noreply.github.com> Date: Sat, 27 Apr 2024 06:56:54 +1000 Subject: [PATCH 1/3] Remove temporary fix d5826e5 for final release --- resources/lib/youtube_plugin/kodion/items/utils.py | 3 --- resources/lib/youtube_plugin/kodion/sql_store/storage.py | 4 ---- 2 files changed, 7 deletions(-) diff --git a/resources/lib/youtube_plugin/kodion/items/utils.py b/resources/lib/youtube_plugin/kodion/items/utils.py index 4bfcbc3a6..aadd3267e 100644 --- a/resources/lib/youtube_plugin/kodion/items/utils.py +++ b/resources/lib/youtube_plugin/kodion/items/utils.py @@ -67,9 +67,6 @@ def from_json(json_data, *args): item = _ITEM_TYPES[item_type](name='', uri='') - if 'data' in json_data and isinstance(json_data['data'], string_type): - return TypeError - for key, value in json_data.get('data', {}).items(): if hasattr(item, key): setattr(item, key, value) diff --git a/resources/lib/youtube_plugin/kodion/sql_store/storage.py b/resources/lib/youtube_plugin/kodion/sql_store/storage.py index ca4256831..eec0588ea 100644 --- a/resources/lib/youtube_plugin/kodion/sql_store/storage.py +++ b/resources/lib/youtube_plugin/kodion/sql_store/storage.py @@ -429,10 +429,6 @@ def _get_by_ids(self, item_ids=None, oldest_first=True, limit=-1, item[0]: self._decode(item[2], process, item) for item in result if not cut_off or item[1] >= cut_off } - for item_id, value in list(result.items()): - if value == TypeError: - self._remove(item_id) - del result[item_id] elif values_only: result = [ self._decode(item[2], process, item) From 52e1f44b61187948195de9b246ccb5de3913e611 Mon Sep 17 00:00:00 2001 From: MoojMidge <56883549+MoojMidge@users.noreply.github.com> Date: Sat, 27 Apr 2024 06:58:46 +1000 Subject: [PATCH 2/3] Version bump v7.0.6 --- addon.xml | 2 +- changelog.txt | 29 +++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/addon.xml b/addon.xml index 83e0f1f69..ea7dab89d 100644 --- a/addon.xml +++ b/addon.xml @@ -1,5 +1,5 @@ - + diff --git a/changelog.txt b/changelog.txt index 353a41e8c..655581233 100644 --- a/changelog.txt +++ b/changelog.txt @@ -1,3 +1,32 @@ +## v7.0.6 +### Fixed +- Improve updating containers and (re)loading windows #681 +- Fix refreshing video listing also forcing next pages to refresh when loaded +- Fix overflow error resulting from parsing hashtags as episode numbers +- Fix 6s delay on video playback start +- Further fixes for multiple busy dialog crash workaround + - Possibly fix issues reported in comments of #704 +- Update error checks to avoid unnecessary retries of player requests +- Fix adding and viewing items to internal bookmarks and watchlater list #720 + +### Changed +- Setup Wizard default settings now disable pre-downloading subtitles if MPEG-DASH is enabled +- Ask for quality, Play with subtitles, Play audio only context menu items only displayed if associated setting is not already enabled +- Only make extra request for subtitles for Android client when all subtitle languages are enabled +- Overhaul alternative player support due to Kodi changes and also improve external player support +- Make "Support alternative player" and "Use YouTube website urls with default player" mutually exclusive options #692 +- Enable OPUS audio by default #537 +- Enable MPEG-DASH for live streams by default #680 +- Setup Wizard will prompt to run when plugin first opens after updating, in order to update default settings +- http server will shutdown on idle timeout #699 + +### New +- Add recommended settings in Setup Wizard for Raspberry Pi 1/2 class devices #688 +- Added Bookmarks + - Save videos, channels, playlists to Bookmarks + - Bookmarked channels will be checked for updates in My Subscriptions + - Data is stored locally, without needing to be logged in + ## v7.0.6+beta.3 ### Fixed - Fix adding and viewing items to internal bookmarks and watchlater list #720 From 9c972b7a9ecc65f3734e41a7646869d00ece034d Mon Sep 17 00:00:00 2001 From: MoojMidge <56883549+MoojMidge@users.noreply.github.com> Date: Sat, 27 Apr 2024 08:47:26 +1000 Subject: [PATCH 3/3] Fix repository workflow failure on push when there is no pre-release user input - need to quote string used for empty string conditional so that an empty input will be expanded to "" - Also use same variable name for input, temporary, and output --- .github/workflows/release-development-repository.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release-development-repository.yml b/.github/workflows/release-development-repository.yml index 603522128..bebd0db07 100644 --- a/.github/workflows/release-development-repository.yml +++ b/.github/workflows/release-development-repository.yml @@ -2,7 +2,7 @@ name: Generate and Publish Development Repositories on: workflow_dispatch: inputs: - prerelease: + pre-release: description: 'Is this a pre-release? [true|false]' required: false default: 'true' @@ -22,14 +22,15 @@ jobs: steps: - name: Get and set release status - # workflow_dispatch: use prerelease variable for release status + # workflow_dispatch: use pre-release variable for release status # push-tag: check tag for alpha|beta|dev to determine release status id: release run: | version=${GITHUB_REF/refs\/tags\//} - if [[ ! -z ${{ github.event.inputs.prerelease }} ]] ; + pre-release=${github.event.inputs.pre-release} + if [[ ! -z "${pre-release}" ]] ; then - echo "pre-release=${{ github.event.inputs.prerelease }}" >> $GITHUB_OUTPUT + echo "pre-release=${pre-release}" >> $GITHUB_OUTPUT elif [[ $version == *[-+]@(alpha|beta|dev)*([.0-9a-z]) ]] ; then echo "pre-release=true" >> $GITHUB_OUTPUT