Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

OAuth2 client_id vs clientId #368

Open
tomkersten opened this issue Oct 9, 2017 · 1 comment
Open

OAuth2 client_id vs clientId #368

tomkersten opened this issue Oct 9, 2017 · 1 comment

Comments

@tomkersten
Copy link
Contributor

The recent refactor for tests resulted in the expected Client ID config param changing from client_id to clientId. Not a big deal once found, however it was undocumented so took a bit to track down. I'm not sure if we want it to be clientId or to restore it to client_id, as all other config params are underscore-based (redirect_uri, etc).

Thoughts?

tomkersten added a commit that referenced this issue Oct 10, 2017
…nality

This restores the previous config parameter name of `client_id` for
OAuth2 providers (e.g. google).

[closes #368]
@camfou
Copy link
Contributor

camfou commented Jun 12, 2018

Hi, this PR fix this issue : #374

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants