Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing the Feedback section styling and adding name and email id for the form #4708

Closed
wants to merge 2 commits into from

Conversation

shriyadindi
Copy link
Contributor

@shriyadindi shriyadindi commented Nov 6, 2024

Related Issue

Enhancing the Feedback section styling and adding name and email id for the form

Fixes: #4687

Description

Enhancing the Feedback section styling and adding name and email id for the form.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot 2024-11-06 191426

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:52pm

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit 3d486e3
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/672b827a6cd6d80008160d7a
😎 Deploy Preview https://deploy-preview-4708--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sailaja-adapa
Copy link
Collaborator

Already present one is fine @shriyadindi no need of email and name
do one thing just align rate us and tell us about your experince text in middle of container
and also your changes were not according to colour theme work with updated branch

@shriyadindi
Copy link
Contributor Author

shriyadindi commented Nov 7, 2024

@sailaja-adapa why are you closing the PR do you know how much effort it takes to create one? Just request the changes in the changes request section and I would work on that, closing the PR and telling to make new changes on a new PR is very disrespectful.

@sailaja-adapa
Copy link
Collaborator

mn
this footer section has been misallgined and also u changed colour theme of rate us container inorder to avoid u unnecessary time waste i just told u to work with updated branch since u directly made changes to index.html
In another PR u raised i didn't closed it right i asked u to delete index.html just to not waste your time and i also thought to assign u good level since i aksed u to make changes again and again

@sailaja-adapa
Copy link
Collaborator

don't take it in bad way if u are working with your current branch it will take lot of time to you to make changes by changing colour correcting footer and also i merged many PR's which will cause you conflicts if u raise PR from your current branch that's why i closed your PR hope u get it @shriyadindi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Enhancing the Feedback section styling and adding name and email id for the form
2 participants