fix: fix edges which connect to combo were filtered in layout stage #6698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request addresses an issue where edges connecting to combos were being filtered out during the layout stage. The changes ensure that both nodes and combos are considered when determining which edges to include in the layout. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -320,12 +320,11 @@ export class LayoutController { | |||
|
|
|||
| const nodesToLayout = nodes.filter(filterFn); | |||
|
|
|||
| const nodesIdMap = new Map<ID, NodeData>(nodesToLayout.map((node) => [idOf(node), node])); | |||
| const nodeLikeIdsMap = new Map<ID, NodeData>(nodesToLayout.map((node) => [idOf(node), node])); | |||
There was a problem hiding this comment.
The variable name nodeLikeIdsMap is more descriptive and accurately reflects its purpose of mapping both nodes and combos, which helps in filtering edges correctly.
yvonneyx
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix edges which connect to combo were filtered in layout stage