Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify rotate and rect classes into one in each case #2

Open
antoniogamiz opened this issue Sep 6, 2020 · 2 comments
Open

Simplify rotate and rect classes into one in each case #2

antoniogamiz opened this issue Sep 6, 2020 · 2 comments
Labels
code Code related (not latex) enhancement New feature or request

Comments

@antoniogamiz
Copy link
Owner

rotate_x, rotate_y and rotate_z, can be simplified as rotate(vec3 & axis, const double theta) where axis is one of {1,0,0}, {0,1,0} or {0,0,1}.

@antoniogamiz
Copy link
Owner Author

axis should be declared as an enum or similar:

enum Axis { x = {1,0,0}, y = {0,1,0}, z = {0,0,1}};

or maybe macros

#define XAXIS {1,0,0}
...

@antoniogamiz antoniogamiz added the code Code related (not latex) label Sep 6, 2020
@antoniogamiz antoniogamiz added the enhancement New feature or request label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code related (not latex) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant