Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): Remove metrics #743

Merged
merged 2 commits into from
Oct 29, 2024
Merged

feat(derive): Remove metrics #743

merged 2 commits into from
Oct 29, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 29, 2024 •
edited
Loading

Description

Part 1 of #721, removing hardcoded metrics from kona-derive to replace them with extensible trait abstractions.

@refcell
Copy link
Collaborator Author

refcell commented Oct 29, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell requested a review from clabby as a code owner October 29, 2024 14:45
@refcell refcell self-assigned this Oct 29, 2024
@refcell refcell added the A-derive Area: kona-derive crate label Oct 29, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@ba454b5). Learn more about missing BASE report.
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/stages/batch/batch_queue.rs 87.5% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clabby
clabby approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, begone janky metrics

@refcell refcell added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 155eea7 Oct 29, 2024
17 checks passed
This was referenced Oct 29, 2024
Closed
Merged
@refcell refcell mentioned this pull request Oct 29, 2024
Open
3 tasks
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
@refcell @fakedev9999
feat(derive): Remove metrics (anton-rs#743)
efdd728 
* feat(derive): remove metrics

* not(test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby