Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect detection of BOM in text with little endian UTF32 encoding #225

Open
mtillmann0 opened this issue Sep 2, 2024 · 0 comments · May be fixed by #226
Open

Incorrect detection of BOM in text with little endian UTF32 encoding #225

mtillmann0 opened this issue Sep 2, 2024 · 0 comments · May be fixed by #226

Comments

@mtillmann0
Copy link

There seems to be a bug in the BOM detection for the UTF32 little endian code path:
https://github.com/antlr/antlr3/blob/master/runtime/C/src/antlr3filestream.c#L235

Note that nextChar+1 is compared three times instead of +1, +2 and +3.
@mtillmann0 mtillmann0 linked a pull request Sep 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UTF32 LE BOM check in C and C++ mtillmann0/antlr3
1 participant
@mtillmann0