-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes for svg #259
base: master
Are you sure you want to change the base?
Made changes for svg #259
Conversation
Required
For the outlined version
Added Snapchat.svg
#237 just solved this issue |
@tangjinzhou @yesmeck @wendellhu95 @afc163 can you review these changes ? |
@Ishaan28malik great, used it on our project and it aligns with other circles perfectly, thank you! @tangjinzhou @yesmeck @wendellhu95 @afc163 any plans to merge it? |
@vagusX Please check this. |
@@ -0,0 +1,4 @@ | |||
<?xml version="1.0" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need the file emtpy-circle
and empty-square
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake to create a checked one I added it.
Could you update your pr summary please? List all changes you made |
@vagusX sure let me re-write the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the description if you want to see the svg
formed for each case then I can add the screenshots
.
@@ -0,0 +1,4 @@ | |||
<?xml version="1.0" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake to create a checked one I added it.
Snapchat seems OK. But other icon we may not accept since antd icons is produced by our designer. |
Please look into it as I have seen occasional need for an empty filled or outlined icons such as circle or square required to show status of various processes. |
Added Snapchat svg for Filled and Outlined versions .
Added empty circle , checked circle and square svg as mentioned in the issue 237