From 021ac7ea3d5e43fb55cffe3a761119f7b748d9ea Mon Sep 17 00:00:00 2001 From: Andrew Crosby Date: Fri, 28 Jan 2022 10:43:14 -0500 Subject: [PATCH] Add pull request template (#1105) Issue: AAH-1219 --- .github/pull_request_template.md | 14 ++++++++++++++ CHANGES/1219.misc | 1 + 2 files changed, 15 insertions(+) create mode 100644 .github/pull_request_template.md create mode 100644 CHANGES/1219.misc diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..935b55b0ac --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,14 @@ +# Description 🛠 +_Add PR description here_ + +# Reviewer Checklists 👀 +Developer reviewer: +- [ ] Code looks sound, good architectural decisions, no [code smells](https://www.codegrip.tech/productivity/everything-you-need-to-know-about-code-smells/) +- [ ] There is a Jira issue associated (note that "No-Issue" should be rarely used) +- [ ] Tests are included in `galaxy_ng/tests/integration` or `galaxy_ng/tests/functional`, and they fully cover necessary test scenarios… or tests not needed + +QE reviewer ([exceptions](https://docs.engineering.redhat.com/display/AUTOHUB/Other+Team+Processes#OtherTeamProcesses-galaxy_ngrepo)): +- [ ] Tests are included in `galaxy_ng/tests/integration` or `galaxy_ng/tests/functional`, and they fully cover necessary test scenarios… or tests not needed +- [ ] PR meets applicable Acceptance Criteria for associated Jira issue + +Note: when merging, include the Jira issue link in the squashed commit diff --git a/CHANGES/1219.misc b/CHANGES/1219.misc new file mode 100644 index 0000000000..bf0c4ab022 --- /dev/null +++ b/CHANGES/1219.misc @@ -0,0 +1 @@ +Add pull request template