Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links should use <Link> instead of button onClick #40

Closed
4 tasks
keithjgrant opened this issue Oct 20, 2022 · 2 comments
Closed
4 tasks

Links should use <Link> instead of button onClick #40

keithjgrant opened this issue Oct 20, 2022 · 2 comments
Assignees
@jamestalton @ZitaNemeckova

Comments

@keithjgrant
Copy link
Member

keithjgrant commented Oct 20, 2022 •
edited by jamestalton
Loading

Multiple links are using buttons with onClick handlers to invoke navigate() instead of rendering regular href's using <Link>

  • Links to documentation in tooltips
  • Nav menu items
  • Detail links in some lists
  • "create X" links in TablePage navbar and empty list page
@keithjgrant keithjgrant changed the title Links should use href instead of button onClick Links should use <Link> instead of button onClick Oct 21, 2022
@jamestalton jamestalton self-assigned this Nov 15, 2022
@jamestalton
Copy link
Contributor

Some of this has been fixed. Need to do further testing.

@gundalow
Copy link

Is this something that we could have CI/linting detect?
I'm not sure what standard linting is available.

@ZitaNemeckova ZitaNemeckova self-assigned this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamestalton jamestalton

@ZitaNemeckova ZitaNemeckova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@keithjgrant @gundalow @jamestalton @ZitaNemeckova