Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commented out code #115

Closed
AlexSCorey opened this issue Dec 9, 2022 · 0 comments
Closed

Remove commented out code #115

AlexSCorey opened this issue Dec 9, 2022 · 0 comments

Comments

@AlexSCorey
Copy link
Member

AlexSCorey commented Dec 9, 2022 •
edited
Loading

There are several places in the repo on main where code is commented out. This should be removed. Moving forward we should make an effort to avoid merging code that is commented out.
Here is 1 case: https://github.com/ansible/ansible-ui/blob/main/proxy/server.ts#L183 and I've seen others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamestalton @AlexSCorey