Package docs build workflow: use relaxed or tested requirements #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oraNod
added
doc builds
This change updates the build package docs workflow to use either relaxed or tested requirements files.
oraNod
force-pushed
the
issue-2270/relaxed-reqs
branch
from
e4e6e55 to
b5695da
Compare
|
Honestly, I wonder if we should just remove the relaxed dependencies file. I never end up using it. If I need to test a requirement change locally, I just edit the main constraints file and re-run pip-compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2270
This change updates the build package docs workflow to use either relaxed or tested requirements files.
I've pushed an additional commit to consolidate the two steps but I'm not sure if it's a good idea. On the one hand, it's tidier in the workflow file but maybe less obvious which set of requirements get installed when looking at the run.