Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE Add ansible-rule-book to ADT #242

Open
cidrblock opened this issue Jun 4, 2024 · 3 comments · May be fixed by #411
Open

RFE Add ansible-rule-book to ADT #242

cidrblock opened this issue Jun 4, 2024 · 3 comments · May be fixed by #411
Labels
enhancement New feature or request

Comments

@cidrblock
Copy link
Contributor

#264

@ssbarnea
Copy link
Member

ssbarnea commented Jun 11, 2024

Few things should happen first:

  • ansible-rulebook to be packaged as an rpm in our beta repositories. As of today, it is not. The projects seems to have a few dependencies that we might not have already packaged if I look at https://github.com/ansible/ansible-rulebook/blob/main/setup.cfg#L25-L38
  • https://pypi.org/project/ansible-rulebook/ does not list any bot account used for publishing and maintenance.
  • incomplete pypi metadata: missing changelog and documentation project links
  • py312 not listed as supported and not tested on GHA
  • add one GHA pipeline running on macos to avoid some surprises
  • recommended dropping setup.cfg and adoption of PEP-517
  • if the projects has any wheels dependencies that are not pure python, they should already have pre-build binaries that cover both amd64 and aarch64 architectures. If not, the build process could because really problematic to maintain (also performance concerns for container building)
  • Good idea to also add an AAP jira ticket to track that and link it here.

If we add it before, we will likely face some tricky problems. None seems hard to address.

@Alex-Izquierdo ^

@ssbarnea ssbarnea added the enhancement New feature or request label Jun 11, 2024
@Alex-Izquierdo
Copy link

Hi @ssbarnea thanks for pinging me.
Agree with most of the points. I will try to push for it.
Why the rpm is a requirement? Which beta repositories are we talking about?

@ssbarnea
Copy link
Member

@Alex-Izquierdo ansible-dev-tools is part of AAP 2.5, adding ansible-rule-book as a dependency would require rpm packaging. You can check the beta repos while on VPN using https://github.com/ansible/team-devtools/blob/main/test/ubi8/Dockerfile (there is one for rhel9 too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants