Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.{2-3} Using /etc/gdm3/greeter.dconf-defaults does NOT make CIS report rules as compliant #124

Closed
ipruteanu-sie opened this issue Oct 3, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ipruteanu-sie
Copy link
Contributor

Describe the Issue
Using /etc/gdm3/greeter.dconf-defaults file does not make CIS report a Pass status for rules 1.8.2 and 1.8.3.

I don't know if you ever tried these steps:

  1. sudo apt update && apt install -y gdm3 on the target Ubuntu system(which forces the condition for above-mentioned rules to be evaluated as True)
  2. Enabling variable which forces 1.8.2 and 1.8.3 rules, respectively: ubtu22cis_desktop_required: true in defaults\main.yml
  3. Running role against Ubuntu system(optionally using gnome as value for tags)
  4. Verify results reported by CIS.

Expected Behavior

  • "1.8.2 | PATCH | Ensure GDM login banner is configured" -> PASS
  • "1.8.3 | PATCH | Ensure disable-user-list is enabled" -> PASS

Actual Behavior

  • "1.8.2 | PATCH | Ensure GDM login banner is configured" -> FAIL
  • "1.8.3 | PATCH | Ensure disable-user-list is enabled" -> FAIL

Control(s) Affected

  • 1.8.2(sce/nix_gdm_login_banner_configured_chk.sh)
  • 1.8.3(sce/nix_gdm_disable_user_list_chk.sh)

Environment (please complete the following information):

  • branch being used: devel

Additional Notes

this common approach suggested by above references works for CIS, but only because it it does not use /etc/gdm3/greeter.dconf-defaults defaults file.

  • It has indeed a reference to OTHER DEFAULTS FILE, respectively /usr/share/gdm/greeter-dconf-defaults:
user-db:user
system-db:gdm
file-db:/usr/share/gdm/greeter-dconf-defaults                      # ** HERE **

, but CIS checks only if disable-user-list=true value is set in dconf-profile files within /etc/dconf/db/*(as highlighted in the below screenshot).
image

Possible Solution
I'll provide a PR, which would make CIS report Pass.
I was wondering, though, if you had some reasons to use the defaults approach, reasons which could make my suggested fix not so good as your original approach.

@ipruteanu-sie ipruteanu-sie added the bug Something isn't working label Oct 3, 2023
@uk-bolly uk-bolly self-assigned this Oct 10, 2023
uk-bolly added a commit that referenced this issue Oct 10, 2023
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly linked a pull request Oct 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants