Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR! 'notify' is not a valid attribute for a Block #226

Closed
jmalpede opened this issue Sep 22, 2023 · 5 comments
Closed

ERROR! 'notify' is not a valid attribute for a Block #226

jmalpede opened this issue Sep 22, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jmalpede
Copy link

Describe the Issue
After updating to main version:
9aa949c playbooks/roles/RHEL8-STIG (3.0.0-18-g9aa949c)
The playbook fails to run.

Expected Behavior
The Playbook should initialize and run without any errors.

Actual Behavior
The Playbook fails with the following error:
amazon-ebs: ERROR! 'notify' is not a valid attribute for a Block
amazon-ebs:
amazon-ebs: The error appears to be in '/home/jmalpede/git/arfam-provision/playbooks/roles/RHEL8-STIG/tasks/fix-cat2.yml': line 826, column 3, but may
amazon-ebs: be elsewhere in the file depending on the exact syntax problem.

Environment (please complete the following information):
$ ansible --version
ansible 2.10.17
config file = None
python version = 3.9.16 (main, Mar 15 2023, 10:32:11) [GCC 4.8.5 20150623 (Red Hat 4.8.5-44)]

main - hash
9aa949c playbooks/roles/RHEL8-STIG (3.0.0-18-g9aa949c)

Additional Notes
If you compare the latest Main to the "working" main, you can see the differences in the ansible syntax.

Possible Solution
The syntax in the fix-cat2.yml file needs to be updated to resolve some ansible formatting issues.
Edit lines 839, 864, 7411 to align notify under the task name, instead of the block.
Those 3 edits resolved the issue locally in our environment.

@jmalpede jmalpede added the bug Something isn't working label Sep 22, 2023
@uk-bolly uk-bolly self-assigned this Sep 22, 2023
uk-bolly added a commit that referenced this issue Sep 22, 2023
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Copy link
Member

hi @jmalpede

Excellent spot and thank you for raising the issue. I have raised PR #227 to pull this into devel as sson as possible.
It is interesting that we are not seeing any errors in syntax check. I will dig into this further.

many thanks

uk-bolly

@jmalpede
Copy link
Author

We use main for hardening our production servers. Is there a date on when the fix will get pushed to main?

@jmalpede
Copy link
Author

I was just wondering when this change will be merged into the "Main" branch? We like to base all our production hardening off of main.
Thanks,
John

@uk-bolly
Copy link
Member

hi @jmalpede

the pipeline had broken since the ansible galaxy updates only allows newer ansible versions. There was also another fix we wanted to get in prior to the next STIG release due to be released very soon.
Hope to get the next PR into devel and main next week.

Thanks

uk-bolly

@uk-bolly
Copy link
Member

uk-bolly commented Apr 9, 2024

hi @jmalpede

I believe this issue has been addressed and merged?
I will close this, but feel free to reopen if you are still experiencing this problem.

many thanks

uk-bolly

@uk-bolly uk-bolly closed this as completed Apr 9, 2024
uk-bolly added a commit that referenced this issue May 24, 2024
Signed-off-by: Mark Bolwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants