Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have a comment argument wherever an object is created #354

Open
11 of 14 tasks
hunleyd opened this issue Oct 12, 2022 · 3 comments
Open
11 of 14 tasks

have a comment argument wherever an object is created #354

hunleyd opened this issue Oct 12, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@hunleyd
Copy link
Collaborator

hunleyd commented Oct 12, 2022

  From a user perspective I think it would be more convenient to have a `comment` argument wherever an object is created. To only change a comment, they need to be idempotent. At a quick glance, the argument would suit 11 modules:

I'd say the benefit of a comment argument or postgresql_comment module over postgresql_query is that we can validate the kind of object which is commented, to avoid SQL injections. As this is part of the query syntax, not a variable, we cannot rely on psycopg2/3 variable escaping.

Originally posted by @betanummeric in https://github.com/ansible-collections/community.postgresql/discussions/352#discussioncomment-3834647

@hunleyd
Copy link
Collaborator Author

hunleyd commented Oct 12, 2022

the comment argument feels like a good thing to me, it must be idempotent, of course.
it can be a shared class/function

@Andersson007
Copy link
Collaborator

Andersson007 commented Dec 10, 2023

Working on it, will be updating the issue description along the way

@hunleyd
Copy link
Collaborator Author

hunleyd commented Dec 20, 2023

thanks for all your efforts to get this work as far along as you did @Andersson007 !

now we just need someone to step up for the remaining three items in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants