Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the inner confusing address naming #123

Closed
XuyangSong opened this issue Feb 8, 2023 · 2 comments · Fixed by #214
Closed

Improve the inner confusing address naming #123

XuyangSong opened this issue Feb 8, 2023 · 2 comments · Fixed by #214
Assignees
Labels
prio:high protocol New protocol or design is needed

Comments

@XuyangSong
Copy link
Collaborator

As described in #108 :

The user_address(user_address = Com( Com(send_vp, nk), recv_vp)) will be removed. Instead, add an inner address variable(address = hash(vp_data_nonhashed, nk_com)). And the address will go to NoteCommitment. Does it make sense that we still use an address here? Otherwise, the vp_data_nonhashed and nk_com will go to NoteCommitment independently, and we need to extend the SinsemillaCommit since we add another 255 bits.

Rename the inner address or extend the SinsemillaCommit.

@XuyangSong XuyangSong self-assigned this Feb 8, 2023
@vveiln
Copy link
Member

vveiln commented Feb 8, 2023

I would say that extending the note commitment would make more sense if we don't need to use this variable somewhere else. I looked through the code quickly and it seems like there is no special use for that structure, but I might be wrong.

If there is a special use (that doesn't apply to other fields of the note, e.g. some special check for app_data_dynamic and nk_com), renaming would work better, but it is hard to tell what should be the new name then

@XuyangSong
Copy link
Collaborator Author

Fix it after we have the key design. #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:high protocol New protocol or design is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants