Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namadillo: IBC -> Review type names #1244

Open
emccorson opened this issue Nov 12, 2024 · 0 comments
Open

Namadillo: IBC -> Review type names #1244

emccorson opened this issue Nov 12, 2024 · 0 comments
Labels
App: Namadillo ibc
Milestone
Mainnet Release

Comments

@emccorson
Copy link
Collaborator

emccorson commented Nov 12, 2024 •
edited
Loading

Some of the type names I added are not very good. Examples:

  • AddressWithAsset
  • AddressWithAssetAndAmount
  • AddressWithAssetAndAmountMap
  • The originalAddress property of AddressWithAsset

We should think of some better names. See the review comments of #1240 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
App: Namadillo ibc
Projects
None yet
Milestone
Mainnet Release
Development

No branches or pull requests
1 participant
@emccorson