Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for “Inflation System”: Rename Cap variables for clarity #406

Open
Rigorously opened this issue Nov 14, 2024 · 0 comments
Open

Comments

@Rigorously
Copy link

Rigorously commented Nov 14, 2024

Cap_PoS is the cap of proof-of-stake reward rate, in units of percent per annum

Meanwhile, Cap_PoS-Epoch is the maximum number of tokens that can be distributed as proof-of-stake rewards per epoch. Based on its name I would have expected Cap_PoS-Epoch to be in units of percent per annum, but it is number of tokens. Seems confusing.

Consider using different names like Max_PoS_Annual_Percentage for Cap_PoS and Max_PoS_Epoch_Tokens for Cap_PoS-Epoch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant