Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible ownership of text strings #30

Open
proycon opened this issue May 17, 2024 · 1 comment
Open

Flexible ownership of text strings #30

proycon opened this issue May 17, 2024 · 1 comment
Assignees
@proycon
Labels
enhancement New feature or request

Comments

@proycon
Copy link
Contributor

proycon commented May 17, 2024

Currently STAM forcibly takes memory ownership of texts (strings), both in TextResource and in DataValue. For more flexible use in situations where the caller wants to retrain ownership, these Strings could be rewritten to Cow<'a,str>. This would be a fairly big refactoring make those structs, and the whole AnnotationStore, subject to a lifetime though.

(not a priority, just an idea)
@proycon proycon added the enhancement New feature or request label May 17, 2024
@proycon
Copy link
Contributor Author

proycon commented May 17, 2024

In such a refactoring for more flexible storage, mmapping() text files could also be taken into consideration as an option

@proycon proycon self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@proycon proycon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@proycon