Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h2.opam: Add constraint on hpack version #213

Closed
reynir opened this issue Mar 21, 2023 · 1 comment · Fixed by #214
Closed

h2.opam: Add constraint on hpack version #213

reynir opened this issue Mar 21, 2023 · 1 comment · Fixed by #214

Comments

@reynir
Copy link
Contributor

reynir commented Mar 21, 2023

In h2.opam we depend on hpack without any constraints. I suspect this is likely usually fine as the interface hasn't changed at all.

ocaml-h2/h2.opam

Line 20 in 9f9f29d

"hpack"

However, due to a behavior in opam-monorepo (tarides/opam-monorepo#331) this lack of constraint makes opam-monorepo choose the wrong version: mirage/mirage#1411 (comment)

To work around the behavior in opam-monorepo we could add a constraint "hpack" {= version} in h2.opam.
@anmonteiro
Copy link
Owner

Not opposed to it. Wanna send a PR?

@reynir reynir mentioned this issue Mar 28, 2023
Merged
@anmonteiro anmonteiro linked a pull request Mar 28, 2023 that will close this issue
Add hpack {= version} constraint #214
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add hpack {= version} constraint reynir/ocaml-h2
2 participants
@reynir @anmonteiro