Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] StudyOptionsFragment: re-include 'total cards' #17489

Open
david-allison opened this issue Nov 23, 2024 · 2 comments
Open

[Proposal] StudyOptionsFragment: re-include 'total cards' #17489

david-allison opened this issue Nov 23, 2024 · 2 comments

Comments

@david-allison
Copy link
Member

david-allison commented Nov 23, 2024

Note

This is not open for implementation until a consensus has been reached

0776858 performs the following change:

  • removes information that isn't shown in the desktop app like the total cards count and total new cards
  • the previous code showed the total cards count in the deck. As the desktop screen didn't show this I removed it. Can be brought back with ease if requested using the cardCount() method which was just added to out codebase.
  • the previous code showed the total new cards count in the deck. As the desktop screen didn't show this I removed it. This can also be brought back for normal decks, however the related backend method doesn't work for filtered decks so we would need to either don't show this count for filtered decks or use the old code(which I'm actively trying to purge).

4 users have requested that this is reinstated:

I'd support reinstating it, but would like consensus before doing so.

@Danika-Dakika
Copy link

@BrayanDSO
Copy link
Member

It seems more like a familiarity issue than a design one. Checking that in statistics is pretty quick, and has even a graph. So staying as is isn't bad.

On the other hand, that whole screen is poorly designed anyway, so adding a thing or two won't spoil something that is already rotten.

Following Newton's first law, I personally prefer to keep things as is. But if people wants to do all the implementation, reviewing and maintenance work, I won't object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants