Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.19.1 crash issues from Acrarium #17370

Open
9 of 17 tasks
mikehardy opened this issue Nov 7, 2024 · 1 comment
Open
9 of 17 tasks

2.19.1 crash issues from Acrarium #17370

mikehardy opened this issue Nov 7, 2024 · 1 comment
Labels
2.19 Help Wanted Requesting Pull Requests from volunteers Priority-Critical

Comments

@mikehardy
Copy link
Member

mikehardy commented Nov 7, 2024

These are the crash issues I see on acrarium when I click "reports" and filter by version "2.19.1"

Note that some may be slightly duplicated, note that some may be carried over from older versions, but all seem like they could be addressed.

Anyone could work on any of these, and/or add more information here, and/or create sub-issues for each one.

Note that you will likely want to fetch the mapping file from the releases page that matches the build type in the given report, then use the retrace Android command line tool to symbolicate / deobfuscate the code

In the absence of anyone else doing something better, my plan is to use this as a task list with these steps:

  1. follow each link and get a count of similar ones in order to rank by priority and group similar ones via indentation here
  2. add a brief title to each one
  3. create a sub-issue for each one as I work on it, with retraced stack trace in the sub-issue
  4. make a PR in as pragmatic a way as possible to stop the crash, see that merged and cherry-pick it for 2.19.2
  5. release 2.19.2 with fewer crashes

Multimedia

Lower Priority

Not new, but no issue existed

Existing

Not Adding an issue

@mikehardy mikehardy added Priority-Critical Help Wanted Requesting Pull Requests from volunteers 2.19 labels Nov 7, 2024
@mikehardy mikehardy added this to the 2.19.2 release milestone Nov 7, 2024
@david-allison
Copy link
Member

david-allison commented Nov 7, 2024

I've edited the issue and added sub-issues

For documentation, the retrace command used was aliased in shell to this:

pbpaste | "${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/retrace" "/Users/${USER}/Downloads/AnkiDroid_current_proguard/build/outputs/mapping/playRelease/mapping.txt" | sed "1d" | pbcopy

(note: I/Mike edited the command slightly to work for current logged in user and "current" mappings now so that the command is stable enough to leave as a persistent shell alias for permanent use :-) )

@david-allison david-allison pinned this issue Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.19 Help Wanted Requesting Pull Requests from volunteers Priority-Critical
Projects
None yet
Development

No branches or pull requests

2 participants