Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Error in conversation with Macello in Home #345

Open
2 of 4 tasks
anubhavpulkit opened this issue Feb 21, 2020 · 11 comments
Open
2 of 4 tasks

Error in conversation with Macello in Home #345

anubhavpulkit opened this issue Feb 21, 2020 · 11 comments

Comments

@anubhavpulkit
Copy link
Contributor

anubhavpulkit commented Feb 21, 2020

Description

The user completes the Home scenario, then the outro sequence occurs. When the outro completes, the Home scenario screen shows briefly and then the Mine Sweeper games appear. This brief appearance of the Home scenario screen should not occur at all.

Mocks

powerup.mov.zip

Acceptance Criteria

Update [Required]

  • [Remove the conversation screen which comes just before Mine Sweeper Game]
    or
  • [Increase the time suspended time of conversation screen with relevant conversation]

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

[4] hours

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie please have a look.
Can I work on this issue?

@sunjunkie
Copy link
Contributor

Yes. But let's add more detail to the issue description. The user completes the Home scenario, then the outro sequence occurs. When the outro completes, the Home scenario screen shows briefly and then the Mine Sweeper games appears. This brief appearance if the Home scenario screen should not occur at all.

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie is it right now?

@sunjunkie
Copy link
Contributor

Remove the 1st paragraph.

@anubhavpulkit
Copy link
Contributor Author

Thank you @sunjunkie

@anubhavpulkit
Copy link
Contributor Author

@sunjunkie I need help on this issue?

@sunjunkie
Copy link
Contributor

Please explain your problem.

@anubhavpulkit
Copy link
Contributor Author

Sorry, @sunjunkie I saw your reply but I want to try more times so I can't give reply to this issue but after some more efforts, I can't understand the relation sequence between popup Event and Story sequence.

@sunjunkie
Copy link
Contributor

@anubhavpulkit
Copy link
Contributor Author

Ok, thank you @sunjunkie I read first one last day. I hope I get some help from 2 or 3 links.

@justkd
Copy link
Contributor

justkd commented Mar 9, 2020

Hi there. So just to be clear the PopupEvents and StorySequences are unrelated. They are separate things entirely. PopupEvents are essentially just notification popups and can be triggered anywhere. StorySequences are the semi-automated dialogue sequences that can occur before and after a scene.

StorySequences aren't pushed with their own view controller. They are just container in a UIView overlaying the current view controller. So, when it's finished, it is disposed of by the scene VC before the minigame VC takes over. The StorySequence class handles removing and disposing of it's own view when the sequence is finished. Resolving this issue might be as simple as not letting it do that...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants