Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : UI Changes in the Sign In page #265

Closed
wants to merge 4 commits into from

Conversation

reachaadrika
Copy link

Description

  1. Updated the UI of Sign In Page
  2. Created 2 new folders , login.jsx and login.css for the same

Fixes #249

Type of Change:

Code

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Screenshot (483)

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@welcome
Copy link

welcome bot commented Jun 30, 2021

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contribution Guidelines.🙌.We will get back to you as soon as we can.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

@stableapple
Copy link
Contributor

@reachaadrika can you please resolve the conflict. You can refer to this link. And please remove package-lock.json file.

<div className="row">
<label>Not yet registered? Click on sign up.</label>
<label>Dont have an Account? Sign Up.</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link this to /register

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Sure @stableapple
Also can you please tell me how to remove package.json?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please tell me how to do I commit latest code to this pull request only ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove the package-lock.json you can do git reset --soft HEAD~1 and then git rm package-lock.json. To resolve the conflict, that is to merge the latest code from the master branch(develop) to your new branch that you are currently working in, you will have to change to the new branch by doing git checkout new_branch. Then set upstream by git remote add upstream https://github.com/anitab-org/bridge-in-tech-web.git followed by git pull upstream develop

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

git pull upstream develop
From https://github.com/anitab-org/bridge-in-tech-web

  • branch develop -> FETCH_HEAD
    Already up to date.

This is what I am getting

@aakankshaagr
Copy link

@reachaadrika footer and show password is missing. Please add them too.

@reachaadrika
Copy link
Author

Yes sure @aakankshaagr , please tell me once how to commit the latest code in this PR , I am facing some issues

@aakankshaagr
Copy link

sure @reachaadrika

  1. Switch to branch you created for solving this issue
  2. add your latest changes (git add .)
  3. commit them
  4. push them
    You will be able to see that commit here

@reachaadrika
Copy link
Author

Thank you so much @aakankshaagr

@stableapple
Copy link
Contributor

stableapple commented Jul 6, 2021

If you are facing issue using the command line, you can resolve the conflicts using the web editor by clicking on the Resolve conflicts button. And please create a separate branch,(other than the develop branch) while submitting your pull requests as this may cause problems in the future.

@reachaadrika
Copy link
Author

@stableapple Noted , Should I make a new PR?

@mtreacy002
Copy link
Member

@stableapple Noted , Should I make a new PR?

@reachaadrika , yes please 😉

@reachaadrika reachaadrika reopened this Jul 8, 2021
@reachaadrika
Copy link
Author

@mtreacy002 Sure , I will close this PR and make a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Develop Sign In page
4 participants