Skip to content

Latest commit

 

History

History
69 lines (34 loc) · 4.13 KB

20220523_line_edits.md

File metadata and controls

69 lines (34 loc) · 4.13 KB

Easy to correct:

l. 52 -- 'This step suggests a chronological exploration of a dataset.' -- delete, it just repeats the header. = Line deleted

l. 66 -- add a small, inline explanation of what 'packages' are. = More explanation added

l. 88 -- 'The package in from the same group' -> 'The package [comes|is|was created by] from the same group...' [typo] = typo fixed

l. 120 -- add a comment to the code, explaining what the function parameters are = parameters are now described

l. 124 -- 'according to different periods in art history to which are represented the most or the least' -- a little confusing, rephrase. Perhaps: '...according to different periods in art history, in order to establish which periods are more or less represented in the National Gallery dataset' = wording changed

l. 195 -- 'beware' -> 'be aware' = Updated

l. 195 -- 'where we collected' -> 'when we collected' = updated

l. 205 -- 'thus creating two lines for;' -> 'which creates two lines in the visualisation, one for...' = updated

l. 209 -- in-line explanation of what 'aesthetics' are in this context = aesthetics are now described

l.209 -- 'tells R, what the' -> 'tells R what the' = comma removed

ll. 245-150 -- explanation of the pipe operator should really come in the first coding section, particularly as you note that 'once you get a hold of this idea the remainder of the data processing will be easier to read and understand' = DONE

l. 255 -- 'verfied' -> 'verified' = DONE

ll. 367-276 -- more detailed explanation of plot construction would be good

l. 382 -- 'two different kinds of distant readings' -> 'two different kinds of distant reading' = DONE

l. 384 -- 'reading individual tweet' -> 'reading individual tweets' = DONE

l. 397 -- First mention of R Markdown -- needs an explanation and a reasoning = Works

l. 414 -- 'are variables that changes' -> 'are variables that change' = DONE

l. 540 -- 'the date of tweets is shown in a way, which is' -> 'the date of tweets is shown in a way which is' = DONE

Needs discussion

l. 34 -- introduces the concept of scalable reading without explanation (only needs a small definition here, something like: ...scalable reading of structured data, a combination of close interpretation of individual texts and statistical analysis of the corpus) - HELLE

#Lesson Aims before #Lesson Structure? - DONE

l. 46 -- 'The reproducible way of selecting...' good that you're introducing examples of disciplines that could use the method, but maybe also add something about its extendibility to others in the humanities. = DONE

l. 52 -- 'Had we worked on data from the National Gallery' -- rephrase, it implies a contradiction with what you said above (that it forms part of the discussion). I.e, 'In the case of the National Gallery data...' - DONE

l. 54 -- 'Had we worked on data from the National Gallery' -- rephrase - DONE

l. 56 -- 'Had we worked on data from the National Gallery' -- rephrase - DONE

#Data and Prerequisites: could not a third option be to offer a base dataset that users can get from PH to get started without having to follow other lessons? - COMMENTARY - MAX

#Data and Prerequisites: add another option, 'Using the rtweet package and your own twitter account, as described below' - DONE

l. 129 (and in the section more generally, and elsewhere in the tutorial) -- the subject changes midway through the sentence: you/we - HELLE

ll. 164-167 -- the code should appear before the explanation, so that readers know what the explanation refers to. Somewhere between ll.142-143. = DONE

ll. 217-228 -- code should be before its explanation = DONE

ll 454-ff -- Why are we exporting the new dataset to a JSON file? i.e., why are we exporting it in the first place, and why specifically using JSON rather than a tabular format (csv, for example)? I still don't see a clear reasoning for it, though I might have missed it of course. = DONE

l. 496 -- 'how many likes you top-20 lies above' -> I don't really understand this sentence, there's a typo or something missing somewhere. = DONE

l.535 -- maybe add a note that fetching the twitter text for each url can also be automated using the API, though it is not covered in this tutorial = LEFT OUT