Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with AIrsenal #4

Open
jack89roberts opened this issue Jul 17, 2021 · 1 comment
Open

Integration with AIrsenal #4

jack89roberts opened this issue Jul 17, 2021 · 1 comment

Comments

@jack89roberts
Copy link
Collaborator

jack89roberts commented Jul 17, 2021

Hi @anguswilliams91 , I finally got round to having a look at this today, and getting some score predictions with ExtendedDixonColesMatchPredictor was really smooth, thanks! 🎉

To get it working in AIrsenal there are 3 functions we use in bpl that are not in bpl-next currently (I think):

  • BPLModel.add_new_team
  • BPLModel.score_n_probability
  • BPLModel.concede_n_probability

I'm happy to help with adding these to bpl-next (to BaseMatchPredictor for the 2nd two?), but may need a hand with add_new_team. We can also implement them on the AIrsenal side instead if you'd prefer not to have them here?

@jack89roberts
Copy link
Collaborator Author

Had a go at the low hanging fruit in #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant