Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/theming): Add palette values to system variables #30070

Open
amysorto opened this issue Nov 22, 2024 · 2 comments
Open

feat(material/theming): Add palette values to system variables #30070

amysorto opened this issue Nov 22, 2024 · 2 comments
Labels
area: theming feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions

Comments

@amysorto
Copy link
Contributor

Feature Description

Prior to the theme mixin you could access palette tone colors from the theme object. It would be useful to add this as system variables for parity. Apps that use the theme mixin don't have a theme object anymore and may still want to access those colors.

Use Case

No response

@amysorto amysorto added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team P4 A relatively minor issue that is not relevant to core functions area: theming and removed needs triage This issue needs to be triaged by the team labels Nov 22, 2024
@MikaStark
Copy link

MikaStark commented Nov 27, 2024

IMO, it could be nice to also have typography variables such like (not just colors) :

--mat-sys-plain-family: Roboto;
--mat-sys-brand-family: Roboto;
--mat-sys-bold-weight: 700;
--mat-sys-medium-weight: 500;
--mat-sys-regular-weight: 400;

@msrumon
Copy link

msrumon commented Nov 29, 2024

This should be among the top-priority todos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: theming feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

No branches or pull requests

3 participants