Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ivy compiler #29

Open
2 of 9 tasks
ChugunovD opened this issue Dec 23, 2019 · 2 comments
Open
2 of 9 tasks

Support Ivy compiler #29

ChugunovD opened this issue Dec 23, 2019 · 2 comments

Comments

@ChugunovD
Copy link

ChugunovD commented Dec 23, 2019

This is a...

  • feature request
  • bug report
  • usage question

What toolchain are you using for transpilation/bundling?

  • @angular/cli
  • Custom @ngTools/webpack
  • Raw ngc
  • SystemJS
  • Rollup
  • Other

Environment

NodeJS Version: v10.15.3
Typescript Version: ~3.6.4
Angular Version: ~9.0.0-rc.6
@angular-redux/store version: ^9.0.0
@angular/cli version: (if applicable) ~9.0.0-rc.6
OS: Windows 10

Link to repo showing the issus

Try to build any Angular project based on Ivy compiller

Expected Behaviour:

Compilation in Prod Successfull

Actual Behaviour:

Compilation Failed

Stack Trace/Error Message:

ERROR in ../node_modules/@angular-redux/router/lib/es5/src/index.d.ts:6:23 - error TS-996005: NgReduxRouterModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If
this occurrence is in library code you don't control, please contact the library authors.

6 static forRoot(): ModuleWithProviders;
~~~~~~~~~~~~~~~~~~~

Additional Notes:

There are need to add Generic for return type ModuleWithProviders in index.ts for NgReduxRouterModule.
Now: static forRoot(): ModuleWithProviders {
Will be: static forRoot(): ModuleWithProviders<NgReduxRouterModule> {

@bstaley
Copy link

bstaley commented Feb 14, 2020

Any update on this? Looks like @ChugunovD has provided a fix. Will anyone be able to make the changes?

@idanaim
Copy link

idanaim commented Mar 22, 2020

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants