-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for f4x1 #231
base: master
Are you sure you want to change the base?
Conversation
Thank you very much for contributing. I tried to build your PR from the command line and got lots of errors. This was the first:
This is using gcc version 7.3.1 |
[redacted to contain only the response relevant to this issue - other issues will be covered separately]
I must admit, that I simply didn't check my change with the examples. That's because I'm using MSYS on Windows which installs Python3, which your examples' scons scripts, as you may be aware, are not compatible with. So, I tested my changes with "examples=no" for all possible F4 targets (just to make sure that I didn't break the existing support). Finally, I tried my change with the examples (after correcting the scons files) and you're obviously right: I got the same errors. The problem is not with my change though, but in the fact that the examples seem to overstate their support in the "compat.txt". The first error you showed is in the first example, the "adc_analog_watchdog" which, despite listing F401 and F411 in the "compat.txt" uses the DAC which is not in these chips. The compilation therefore, correctly fails, as the code tries to use non existing hardware.
I'm happy to go through all the examples and correct their "compat" files.
I could then update my PR with these changes.
|
I have the examples built correctly, but haven't pushed my changes yet, because I'd like to ask you Andy for your preference. What's your preference? |
I think I would prefer separate folders for the F401 and F411 that are clocked at 84MHz. The earlier devices that can run at 168MHz should still run at that speed. |
I added support for the STM32F401 and STM32F411 chips. Briefly tested with both (on Black Pill modules)