Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for f4x1 #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slavdors
Copy link
Contributor

@slavdors slavdors commented Mar 2, 2021

I added support for the STM32F401 and STM32F411 chips. Briefly tested with both (on Black Pill modules)

@andysworkshop
Copy link
Owner

Thank you very much for contributing. I tried to build your PR from the command line and got lots of errors. This was the first:

$ scons mode=debug mcu=f401 hse=8000000
scons: Reading SConscript files ...
stm32plus build version is 040100
scons: done reading SConscript files.
scons: Building targets ...
arm-none-eabi-g++ -o examples/adc_analog_watchdog/build/debug-f401-8000000e/adc_analog_watchdog.o -c -Wextra -pedantic-errors -fno-rtti -std=gnu++14 -fno-threadsafe-statics -Wall -Werror -Wno-implicit-fallthrough -ffunction-sections -fdata-sections -fno-exceptions -mthumb -gdwarf-2 -pipe -DHSE_VALUE=8000000 -mcpu=cortex-m4 -DSTM32PLUS_F401 -O0 -g3 -Ilib/include -Ilib/include/stl -Ilib -Iexamples/adc_analog_watchdog examples/adc_analog_watchdog/adc_analog_watchdog.cpp
In file included from lib/include/config/dac.h:35:0,
                 from examples/adc_analog_watchdog/adc_analog_watchdog.cpp:10:
lib/include/dac/features/DacFeatureBase.h:19:7: error: 'Dac' does not name a type
       Dac& _dac;
       ^~~

This is using gcc version 7.3.1

@slavdors
Copy link
Contributor Author

slavdors commented Mar 16, 2021 via email

@slavdors
Copy link
Contributor Author

I have the examples built correctly, but haven't pushed my changes yet, because I'd like to ask you Andy for your preference.
The system files for f4xx in the examples assume 168MHz system clock which is way too high for f401 and f411. I could either lower it down to 84MHz to cover all versions of f4xx or create separate folders with the proper corresponding system files for each f401 and f411.

What's your preference?

@andysworkshop
Copy link
Owner

I have the examples built correctly, but haven't pushed my changes yet, because I'd like to ask you Andy for your preference.
The system files for f4xx in the examples assume 168MHz system clock which is way too high for f401 and f411. I could either lower it down to 84MHz to cover all versions of f4xx or create separate folders with the proper corresponding system files for each f401 and f411.

What's your preference?

I think I would prefer separate folders for the F401 and F411 that are clocked at 84MHz. The earlier devices that can run at 168MHz should still run at that speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants